LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250710202354753 to main#62038
Merged
jakebailey merged 1 commit intomainfrom Jul 10, 2025
Conversation
typescript-bot
added
the
For Uncommitted Bug
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the diagnostic message for the rule about using 'Object' as a class name when targeting ES5, extending it to cover ES5 and above across multiple localized files.
- Renamed the
ItemIdto include “and_above” instead of “with_module” - Updated the English source message and all localized target strings accordingly
- Applies changes in Turkish, Russian, Polish, Italian, Spanish, German, and Czech
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/loc/lcl/trk/diagnosticMessages/diagnosticMessages.generated.json.lcl | Updated ItemId and message text to cover “ES5 and above” |
| src/loc/lcl/rus/diagnosticMessages/diagnosticMessages.generated.json.lcl | Same as above |
| src/loc/lcl/plk/diagnosticMessages/diagnosticMessages.generated.json.lcl | Same as above |
| src/loc/lcl/ita/diagnosticMessages/diagnosticMessages.generated.json.lcl | Same as above |
| src/loc/lcl/esn/diagnosticMessages/diagnosticMessages.generated.json.lcl | Same as above |
| src/loc/lcl/deu/diagnosticMessages/diagnosticMessages.generated.json.lcl | Same as above |
| src/loc/lcl/csy/diagnosticMessages/diagnosticMessages.generated.json.lcl | Same as above |
Comments suppressed due to low confidence (2)
src/loc/lcl/trk/diagnosticMessages/diagnosticMessages.generated.json.lcl:4070
- Add or update unit and localization tests to verify that the updated message is produced when targeting ES5 and above with a module. This ensures the change is covered by automated tests.
<Item ItemId=";Class_name_cannot_be_Object_when_targeting_ES5_and_above_with_module_0_2725" ItemType="0" PsrId="306" Leaf="true">
src/loc/lcl/trk/diagnosticMessages/diagnosticMessages.generated.json.lcl:4070
- Ensure that all references to this diagnostic ID in the compiler and tests are updated to match the new
Class_name_cannot_be_Object_when_targeting_ES5_and_above_with_module_0_2725. If any code still refers to the old ID, the message may no longer be emitted correctly.
<Item ItemId=";Class_name_cannot_be_Object_when_targeting_ES5_and_above_with_module_0_2725" ItemType="0" PsrId="306" Leaf="true">
| @@ -4067,11 +4067,11 @@ | |||
| </Str> | |||
There was a problem hiding this comment.
Since these are generated files, consider updating the localization generator or template rather than modifying each language file manually to reduce duplication and risk of drift in future updates.
jakebailey
approved these changes
Jul 10, 2025
jakebailey
deleted the
lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250710202354753
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEGO: Pull request from lego/hb_5378966c-b857-470a-8675-daebef4a6da1_20250710202354753 to main with localized lcls